Does vBulletin do Code Reviews?

I see another thread 'locked' but still a VERY valid point..

Shamil. posted this

An honest question to vBulletin.

Do you guys do code reviews?

I mean, I just opened index.php, acting as a front controller, and after being faced with a wall of code with singletons (I'm going to try to find where a code was instantiated without a singleton or multiton), I saw something horrific..

Code:

switch ($controller) {
 
 
case 'activity':
 
 
$class = 'Activity';
 
 
break;
 
 
case 'admin':
 
 
$class = 'Admin';
 
 
break;
 
 
case 'ajax':
 
 
$class = 'Ajax';
 
 
break;
 
 
case 'auth':
 
 
$class = 'Auth';
 
 
break;
 
 
case 'channel':
 
 
$class = 'Channel';
 
 
break;
 
 
case 'conversation':
 
 
$class = 'Conversation';
 
 
break;
 
 
case 'createcontent':
 
 
$class = 'CreateContent';
 
 
break;
 
 
case 'poll':
 
 
$class = 'Poll';
 
 
break;
 
 
case 'page':
 
 
$class = 'Page';
 
 
break;
 
 
case 'test':
 
 
$class = 'Test';
 
 
break;
 
 
case 'uploader':
 
 
$class = 'Uploader';
 
 
break;
 
 
case 'search':
 
 
$class = 'Search';
 
 
break;
 
 
case 'filedata':
 
 
$class = 'Filedata';
 
 
break;
 
 
case 'registration':
 
 
$class = 'Registration';
 
 
break;
 
 
case 'profile':
 
 
$class = 'Profile';
 
 
break;
 
 
case 'style':
 
 
$class = 'Style';
 
 
break;
 
 
case 'video':
 
 
$class = 'Video';
 
 
break;
 
 
case 'link':
 
 
$class = 'Link';
 
 
break;
 
 
case 'relay':
 
 
$class = 'Relay';
 
 
break;
 
 
case 'privatemessage':
 
 
$class = 'PrivateMessage';
 
 
break;
 
 
case 'report':
 
 
$class = 'Report';
 
 
break;
 
 
case 'hv':
 
 
$class = 'Hv';
 
 
break;
 
 
default:
 
 
$class = 'Main';
 
 
break;
 
 
}
 
$class = 'vB5_Frontend_Controller_' . $class;
 
 
 
 
 
if (!class_exists($class))
 
 
{
 
 
// @todo - this needs a proper error message
 
 
die("Couldn't find controller file for $class");
 
 
}

(forget about throwing exceptions here that we couldn't find the controller class), but die()?

I can't imagine things getting any easier with 588k lines of code.

 

I would not be surprised if IB / vBS would have been quite aware about the quality of the product, even before the first line of code was written.

 

Oh... What the **ck. ... even I (I'm not a professional coder.) can see how bad it is. Is this even a code? Can piece of not working crap deserve for being called a code?